oasisprotocol / oasisprotocol/oasis-core
Flags refactoring followup
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 369
- Forks
- 151
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 6
Description
More desired changes following #2045
Details
- Some flag sets are intended only to have a single flag. Let's change these just to be a flag instead of a flag set.
- Some flag sets are (i) private, (ii) only used once in a Register(parentCmd) and (iii) contain some non-original flags. Maybe there's a way to clean these up by inlining the non-original flag set merges into the Register function.
Acceptance Criteria
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the changes from #2045 and the flag definitions used by Register(parentCmd). Identify single-flag sets and private, single-use sets containing non-original flags. Done means the requested simplifications are applied while preserving registration behavior; no specific files or tests are named in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100