oasisprotocol / oasisprotocol/oasis-core
go/worker: Don't always start the registration worker
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 369
- Forks
- 151
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 6
Description
Right now the registration worker is always spun up, if workers are. This is somewhat silly and it should only happen if the node needs to actually register the node descriptor with the registry (the client spins up workers, so it also pulls this in, but it doesn't have an entity etc).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the go/worker registration-worker startup path and trace how worker creation distinguishes nodes from clients. Verify when a node descriptor must be registered, then ensure the registration worker is started only in that case; clients without an entity should not start it. Add or update focused tests if the existing worker tests cover this path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- blockchain
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100