oasisprotocol / oasisprotocol/oasis-core
go/storage/mkvs/urkel: Internal cache locking should use RWMutex for better performance
Open
Nobody has claimed this yet.
c:storage
golang
s:good first issue
- Dominant language
- Go
- Stars
- 369
- Forks
- 151
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 6
Description
PR #1785 fixed a data race condition by adding locking to the internal Urkel tree cache, but the implementation could be improved further by distinguishing between accesses that need only a read lock and accesses that need a write lock.
Acceptance Criteria
- Urkel tree internal cache uses RWMutex for locking.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing PR #1785 and the Urkel tree's internal cache locking implementation. Distinguish cache accesses that need read locking from those that need write locking, then verify the acceptance criterion that the cache uses RWMutex.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- blockchain, databases
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100