oasisprotocol / oasisprotocol/explorer
Do we need alwaysWaitWhileLoading?
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13
- Forks
- 13
- Avg merge
- 58m
- Merged PRs (30d)
- 2
Description
Related to https://github.com/oasisprotocol/explorer/pull/691#discussion_r1258940735
the current implementation of
Tableonly considersisLoadinif there are no rows:{!rows && isLoading && ( <SkeletonTableRows rowsNumber={rowsNumber} columnsNumber={columns.length} /> )}
Some tables now have isLoading combining multiple requests, so rows may be available with partial data that we don't want to show yet (we have alwaysWaitWhileLoading now). On the other hand, do any tables have isLoading but data is ready to display (does any table ever rely on !rows)?
Can we unify the behavior? If not, which behavior should be the default?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/app/components/Table/index.tsx around the loading condition quoted in the issue. Search the repository for Table usages, isLoading combinations, and alwaysWaitWhileLoading to determine which tables depend on each behavior. Done means the behavior question is resolved with the relevant usages identified and any required consistency change scoped.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100