oasisprotocol / oasisprotocol/explorer
[Feature]: We should use better names for screen sizes
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13
- Forks
- 13
- Avg merge
- 58m
- Merged PRs (30d)
- 2
Description
Is there an existing issue for this?
- I have searched the existing issues
SUMMARY
The current names we are using for screen sizes are misleading
DESCRIPTION
We have a hook useScreenSizes() for checking screen sizes. However, the values we are returning here don't mean what the names suggest they mean. For example we have isTable which does not mean that we are working with a tablet screen, but that we are working at most on a tablet screen, ie. either on a mobile or a tablet. The names should reflect that.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the useScreenSizes() hook and inspect its returned screen-size names and their consumers. Rename the values so their names describe the maximum supported screen size, then update affected references and verify the explorer still builds and behaves consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100