oasisprotocol / oasisprotocol/explorer
[Bug]: Commission rate should have at least one decimal
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13
- Forks
- 13
- Avg merge
- 58m
- Merged PRs (30d)
- 2
Description
Is there an existing issue for this?
- I have searched the existing issues
STEPS TO REPRODUCE
The commission rate should not be rounded in the UI. For example https://explorer.oasis.io/mainnet/consensus/validators/oasis1qzg6dct605z9vm5d265uzskqj6szhkx3zugae2a3:
Has actual commission rate 0.1%:
$ oasis network show oasis1qzg6dct605z9vm5d265uzskqj6szhkx3zugae2a3 --network mainnet
=== ENTITY ===
Entity Address: oasis1qzg6dct605z9vm5d265uzskqj6szhkx3zugae2a3
Entity ID: 1kZdUPgo42/mQB8rIsCQBPeqkJr1VEBX+4lZfUo6bAA=
Stake: 5279787.384975804 ROSE
Commission: 0.1%
=== NODES ===
Node Address: oasis1qpe0vnm0ahczgc353vytvtz9r829le4pjux8lc5z
Node ID: UZ3Fz1nYHt41zR1eyL1g0kocea3WMUsbfoAkOvBcZko=
Node Roles: validator
Software Version: 26.0-git76002fa95+dirty
Node Status:
Expiration Processed: false
Freeze End Time: 0
Election Eligible After: 49571
EXPECTED BEHAVIOR
I would have a one-decimal for commission rate both on the validators list page and in the specific validator page.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the commission-rate display on the validators list page and the specific validator page in the TypeScript frontend. Compare the displayed value with the 0.1% value shown by the Oasis network command. Done means both UI locations show commission rates with at least one decimal place.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- blockchain, typescript
- Domain
- blockchain, frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100