oasisprotocol / oasisprotocol/explorer

ui-library changes not always propagating

Open
#2,286 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

devex
Dominant language
TypeScript
Stars
13
Forks
13
Avg merge
58m
Merged PRs (30d)
2

Description

When changing ui-library inside explorer or rofl, I noticed sometimes changes do not propagate.
yarn && yarn dev --force does not fix it. Sometimes I have to do yarn add file:./ui-library.

steps

  • edit ./ui-library/src/components/ui/dialog.tsx
  • expect yarn to update node_modules/ui-library/src/components/ui/dialog.tsx, but it doesn't

maybe yarn add link:./ui-library would work better? Or some vite config

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the steps with ./ui-library/src/components/ui/dialog.tsx, comparing the change in node_modules/ui-library/src/components/ui/dialog.tsx after yarn and yarn dev --force. Read the package setup and any Vite configuration for explorer or rofl, then verify that edits propagate without manually running yarn add file:./ui-library or using a link dependency.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vite
Domain
build-system, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.