oasisprotocol / oasisprotocol/explorer

LinkableDiv get stuck halfway due to loading states

Open
#1,949 0 comments 0 reactions 1 assignee View on GitHub

@kaja-osojnik is already working on this.

Since May 23, 2025.

Dominant language
TypeScript
Stars
13
Forks
13
Avg merge
58m
Merged PRs (30d)
2

Description

https://explorer.dev.oasis.io/mainnet/sapphire/address/0x6665a6Cae3F52959f0f653E3D04270D54e6f13d8/events#events

  • events load slowly
  • LinkableDiv tries to scroll to #events
  • it hits end of the page, so it only scrolls half way and stops
  • events finish loading
  • displayed events extend the page
  • LinkableDiv doesn't scroll again

I think LinkableDiv should only start scrolling when isLoading=false.
(if loading takes a long time then user may start scrolling towards something else. We shouldn't interrupt that?)

Either LinkableDiv should require isLoading prop so it doesn't get stuck halfway or
simple alternative: make loading skeletons much larger

Image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.