oasisprotocol / oasisprotocol/explorer

Migrate outOfDate to outOfDateReason

Open
#1,933 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
13
Forks
13
Avg merge
58m
Merged PRs (30d)
2

Description

It looks like redundancy in having two vars for handling one state. Doesn't outOfDate duplicate outOfDateReason? Would be simpler to have single source of truth for this state checking.

Originally posted by @buberdds in https://github.com/oasisprotocol/explorer/pull/1876#discussion_r2059764138

(be careful not to break undefined vs false differentiation)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate all references to outOfDate and outOfDateReason and trace how their values are used. Confirm the migration preserves the distinction between undefined and false; done means the redundant state is removed without changing that behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.