oasisprotocol / oasisprotocol/explorer

Refactor form validation patterns

Open
#1,418 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
13
Forks
13
Avg merge
58m
Merged PRs (30d)
2

Description

Is there an existing issue for this?
  • I have searched the existing issues
SUMMARY

Some of the form validation logic should/could be refactored

See https://github.com/oasisprotocol/explorer/pull/689#discussion_r1255676146 and https://github.com/oasisprotocol/explorer/pull/1357#discussion_r1603218256

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the discussions linked from pull requests 689 and 1357, then locate the form validation logic they reference. Compare the existing validation patterns and determine the intended common approach from those discussions. Done means the validation patterns are refactored consistently without changing the expected form behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.