oasisprotocol / oasisprotocol/cli
cli: Use import instead of create to open Ledger account
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 80
- Forks
- 23
- Avg merge
- 9h 43m
- Merged PRs (30d)
- 3
Description
Term "create" should be used if the CLI generates a new keypair. When adding a Ledger account into the wallet, CLI doesn't generate or overwrite anything, but just registers existing Ledger account to the CLI.
Use oasis wallet import to add the Ledger account instead of oasis wallet create. In this case importing would also be done interactively so the user can see the Ledger option and easily provide the key derivation index (no need for non-obvious --kind ledger and --number x flags). This also makes the CLI flow consistent with Oasis wallet web and extension.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the implementations of the oasis wallet create and oasis wallet import commands, then compare their current interaction flows. The change is done when adding a Ledger account uses import, offers the Ledger option interactively, accepts the key derivation index, and remains consistent with the requested wallet flow.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- blockchain, cli
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100