oasisprotocol / oasisprotocol/cli

`wallet import`: Check whether Ed25519 keypair is valid

Open
#219 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement wallet
Dominant language
Go
Stars
80
Forks
23
Avg merge
9h 43m
Merged PRs (30d)
3

Description

The oasis web wallet checks whether the public key corresponds to the secret key when importing the 64- byte Ed25519 keypair (https://github.com/oasisprotocol/oasis-wallet-web/pull/1007).

The CLI should do the same.

OPTIONALLY: Support importing the 32-byte secret key only and print a warning that this is very unsafe.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the CLI's wallet import command and review how it handles 64-byte Ed25519 keypairs. Compare the validation behavior described in oasis-wallet-web/pull/1007; done means rejecting a mismatched public and secret key, with the optional 32-byte import warning handled explicitly if pursued.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
blockchain, cli, cryptography
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.