oakmac / oakmac/standard-clojure-style-js

remove whitespace after dispatch char?

Open
#198 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

formatting rules
Dominant language
JavaScript
Stars
137
Forks
8
PR merge metrics
No merged PRs in 30d

Description

From this comment on PR-195, should Standard Clojure Style remove whitespace after the dispatch character # for certain forms?

Some examples:

## NaN
##NaN

#:user {:a 1}
#:user{:a 1}

#::u {:a 1}
#::u{:a 1}

#:: {:a 1}
#::{:a 1}

#inst "2014-05-19T19:12:37.925-00:00"
#inst"2014-05-19T19:12:37.925-00:00"

#js {:onClick (fn [e] (js/console.log e))}
#js{:onClick (fn [e] (js/console.log e))}

#? (:clj true :cljs false}
#?(:clj true :cljs false}

#?@ (:clj [:a :b :c])
#?@(:clj [:a :b :c])

#= (* 2 3)
#=(* 2 3)

cc @yuhan0 - thank you for this suggestion and the examples!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked PR-195 discussion and inspect the formatter's handling of the dispatch character in the examples listed here. Determine the intended whitespace behavior for each form, then verify that the chosen behavior is covered for the shown cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure, javascript
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.