oakmac / oakmac/standard-clojure-style-js

Remove blank behaviour in different cases

Open
#156 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug help wanted
Dominant language
JavaScript
Stars
137
Forks
8
PR merge metrics
No merged PRs in 30d

Description

Hi, just watched your conj talk, this is cool - your efforts are appreciated.

Came across two different cases in different editors
Pic instead code block because it shows blankspaces.

In first case, which by default in my vscode setup
image
will be formatted to

(cond
  :cond-1
  :do-1
  :cond-2
  :do-2
  :cond-3
  :do-)

but(which default in my cursive setup)
image
will be formatted with respect to blank lines to

(cond
  :cond-1
  :do-1

  :cond-2
  :do-2

  :cond-3
  :do-)

I would personally prefer to respect empty lines, but I wonder which behavior is considered preferable and whether the formatter behaves correctly in both cases?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the two formatting examples from the issue in the relevant editor setups and inspect how the formatter handles blank lines. Confirm which behavior is intended, then verify that the chosen behavior is consistent for the shown Clojure forms.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure, javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.