nwjs / nwjs/chromium.src

[BUG] headless_shell_switches.cc missing when build nw in branch nw83

Open
#162 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
160
Forks
127
PR merge metrics
No merged PRs in 30d

Description

when I run ninja -C out/nw nwjs in branch nw83, it throw error like
ninja: error: '../../headless/app/headless_shell_switches.cc', needed by 'obj/headless/headless_shell_lib/headless_shell_switches.o', missing and no known rule to make it
I found the headless_shell_switches.cc was deleted in branch nw73

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failure with ninja -C out/nw nwjs on branch nw83 and inspect the dependency on headless/app/headless_shell_switches.cc. Compare that path and its references with branch nw73, where the file was reportedly deleted. Done means the missing dependency is resolved and the nwjs build completes.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.