nwjs / nwjs/chromium.src

Crash on Windows Debug Build

Open
#134 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
160
Forks
127
PR merge metrics
No merged PRs in 30d

Description

@rogerwang I am experiencing crash issue with Windows DEBUG build, on this line:
https://github.com/nwjs/chromium.src/blob/9fece9b27a132d4c9430a9c1e9d7fe9e8bf24d32/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc#L686

if I disable the ::HeapFree and just use "free", everything looks fine
any reason why you are using HeapFree? I can't find the correspondent HeapCreate

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at third_party/blink/renderer/bindings/core/v8/v8_initializer.cc:686 and inspect the surrounding Windows DEBUG allocation and cleanup paths. Trace whether the HeapFree call has a matching HeapCreate, comparing it with the reported free() behavior. Done means identifying the cause of the crash and documenting or correcting the ownership mismatch with a focused regression check.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.