nvimdev / nvimdev/lspsaga.nvim
count never increment
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 3.8k
- Forks
- 308
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
I met the same issue discussed here.
hover request is always pending when matched clients's num is more than 1.
I think there are some problems in this function because count will never increment if matched clients's num is more than 1 since lsp.buf_request is called once if I understand correctly.
I have little knowledge about neovim plugins,feel free to close this if I'm wrong
Steps to reproduce
just setup two more lsp clients.
For example 'tailwindcss' and `tsserver' then enter a tsx file.
Expected behavior
maybe remove count or send multiple requests?
Neovim version (nvim -v)
NVIM v0.10.0-dev-1809+g529498685
lspsaga commit
335805d4f591f5bb71cabb6aa4dc58ccef8e8617
Terminal name/version
alacritty 0.12.3 (5efb0690)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lua/lspsaga/hover.lua at the function around line 223 and inspect how lsp.buf_request and count are used when multiple clients match. Reproduce with tailwindcss and tsserver in a TSX file; done means the hover request no longer remains pending when more than one client is available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100