nvim-tree / nvim-tree/nvim-web-devicons

Include filetypes from `filetypes.lua` in checks

Open
#560 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
2.7k
Forks
239
Avg merge
3d 16h
Merged PRs (30d)
3

Description

Not all filetypes will have syntax files (I think), so while checking for missing filetypes in https://github.com/nvim-tree/nvim-web-devicons/blob/master/scripts/filetypes.sh#L10-L20 we should, on top of presence of syntax/<filetype>, check $VIMRUNTIME/lua/vim/filetype.lua as well.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read scripts/filetypes.sh, especially lines 10-20, and compare its syntax/ check with $VIMRUNTIME/lua/vim/filetype.lua. Done means the check also recognizes filetypes defined in that Lua file.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua, shell, vim
Domain
tooling
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.