nvim-tree / nvim-tree/nvim-tree.lua

Handle git.timeout For All Git Calls

Open
#3,278 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
8.6k
Forks
639
Avg merge
1d 14h
Merged PRs (30d)
2

Description

git/utils system passes a timeout to vim.system however that timeout is not handled and reported to the user in a friendly manner. It silently stops git operations.

Discovered during #3251 which is hackily resolved by passing the timeout to :wait.

The following are the only users of system and should handle timouts in the same manner as GitRunner:

  • should_show_untracked
  • get_toplevel

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with git/utils system and compare timeout handling with GitRunner. Trace its two listed users, should_show_untracked and get_toplevel, and review how vim.system timeouts currently behave. Done means both callers report timed-out git operations to the user in the same manner as GitRunner.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.