nvim-tree / nvim-tree/nvim-tree.lua

Multi Instance: Refactor: move core.get_cwd function into explorer

Open
#3,224 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
8.6k
Forks
639
Avg merge
1d 14h
Merged PRs (30d)
2

Description

  • #2255

Independent of #2836

Some core functions operate directly on an Explorer instance and can be moved in there:
get_cwd

Some dependency cycles may be reduced after refactor e.g.
https://github.com/nvim-tree/nvim-tree.lua/blob/a4699c0904103e7767334f6da05f5c2ea5514845/lua/nvim-tree/view.lua#L306

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating core.get_cwd and the Explorer implementation, then inspect the referenced view.lua location around line 306 for current dependencies. Move the function into Explorer and verify that its callers still work without the former core dependency; the refactor is done when the relevant dependency cycle is reduced.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
devtools
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.