nvim-tree / nvim-tree/nvim-tree.lua
Enable `undefined-field` Check: Strongly Type NodeIterator
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 8.6k
- Forks
- 639
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 2
Description
NodeIterator is not strongly typed and violates undefined-field checks.
Variants to iterate files / directories etc. need to be created, and those filters/checks in the NodeIterator usages removed.
This has a high blast radius and would benefit greatly from a test framework to validate current and new behaviour.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating NodeIterator and every usage that performs file, directory, or similar filters. Determine how variants and checks currently preserve behavior, then add the test coverage needed to validate both existing and new behavior; done means NodeIterator satisfies undefined-field checks without those usage-side filters.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100