nvim-tree / nvim-tree/nvim-tree.lua
Multi Instance: Refactor: move core.get_nodes_starting_line function into explorer
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 8.6k
- Forks
- 639
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 2
Description
- #2255
Independent of #2836
Some core functions operate directly on an Explorer instance and can be moved in there:
get_nodes_starting_line
Many dependency cycles can be broken after removal e.g.
https://github.com/nvim-tree/nvim-tree.lua/blob/64e2192f5250796aa4a7f33c6ad888515af50640/lua/nvim-tree/explorer/live-filter.lua#L207
may be replaced with a direct call to self.explorer
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating core.get_nodes_starting_line and the Explorer implementation, then inspect lua/nvim-tree/explorer/live-filter.lua around line 207. Trace how the function operates on Explorer instances and assess the direct self.explorer call; done means the function is moved appropriately and the cited dependency path no longer relies on core.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100