nvim-tree / nvim-tree/nvim-tree.lua

File operations should consider adding quotes when dealing with spaces

Open
#2,681 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

API feature request
Dominant language
Lua
Stars
8.6k
Forks
639
Avg merge
1d 14h
Merged PRs (30d)
2

Description

Is this a question?
Please start a new Q&A discussion instead of raising a feature request.

Can this functionality be implemented utilising API?
No, and it would make sense to change this for a better default behavior.

Is your feature request related to a problem? Please describe.
When hitting . while being on an object in the tree, it will enter command mode while having the absolute path already inserted. This is nice and all, until the absolute path contains spaces.

Describe the solution you'd like
I think it would make sense to surround the path with quotes by default to circumvent the problem.

Describe alternatives you've considered
Inserting it on my own, but it feels repetitive.

Additional context
It should be discussed if quotes can cause any problems. I only ever use this feature to launch OS specific commands with bang, so I don't know.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation of the . action that enters command mode and inserts the absolute path. Check how paths containing spaces are currently handled and whether quoting affects bang commands. Done means paths with spaces work by default without breaking the existing command behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.