nvim-orgmode / nvim-orgmode/orgmode

`org-log-into-drawer` logs todo keywords with exclamation mark

Open
#552 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
3.9k
Forks
190
Avg merge
2d 13h
Merged PRs (30d)
7

Description

From reproducing in emacs, our current behavior matches that in emacs. For non-repeating TODO, nothing is logged, for repeating it is logged and for repeating with org-log-into-drawer set, it logs into the given drawer. For non-repeating, the state is changed, for repeating it is not (or actually, it is moved to DONE and then immediately back to TODO), just as in emacs.

Also note that this PR doesn't change the behavior of logging state changes, only its location in case the option is set

Also note that this PR doesn't change the behavior of logging state changes, only its location in case the option is set. Logging a note on a plain headline (and forcing logging on a single state change), done in emacs with C-u C-c C-t is something we want to have, but not in scope for this PR I think.

edit: did some editing by accident, should be 'reverted' (-Jonas)

Originally posted by @Jesse-Bakker in https://github.com/nvim-orgmode/orgmode/issues/531#issuecomment-1477511420

org-todo-keywords equals to "TODO(t!)" "|" "DONE(d!)" then is logged into the drawer

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is identified in the issue. Reproduce the case with org-todo-keywords set to "TODO(t!)" and "DONE(d!)", then trace the org-log-into-drawer and todo-state logging entry points; done should be defined by an agreed correction to where the keyword with an exclamation mark is logged.

Written by the indexing model from the issue text.

Assessment

Tech stack
emacs, lua, neovim
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.