nvim-orgmode / nvim-orgmode/orgmode

Help windows do not inherit `NormalFloat` highlight

Open
#510 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
3.9k
Forks
190
Avg merge
2d 13h
Merged PRs (30d)
7

Description

The highlights for the help menu don't match the same highlights used for the agenda/capture (if those are set to floats)

Screenshot 2023-02-25 at 09 16 44

Other than the win_split_mode = 'float' and the border I haven't changed anything window related so I think the highlights just have different values set 🤔

Originally posted by @akinsho in https://github.com/nvim-orgmode/orgmode/issues/509#issuecomment-1445038705

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the help menu with win_split_mode = 'float' and compare its highlights with the agenda and capture windows when they also use floats. Trace the help-menu and float highlight setup, then verify that the help highlights match NormalFloat and the existing agenda/capture appearance.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.