nvim-mini / nvim-mini/mini.nvim
[mini.completion] respect vim.o.complete for nvim-0.12+ ?
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 9.5k
- Forks
- 310
- Avg merge
- 4h 16m
- Merged PRs (30d)
- 1
Description
Contributing guidelines
- I have read CONTRIBUTING.md
- I have read CODE_OF_CONDUCT.md
Module(s)
mini.completion
Description
Previously the default vim.o.complete of '.,w,b,u,t' would cause slowdowns in mini-completion, even if the user didn't use ctags.
A workaround was added to remove t unless user explicitly sets it via eb4d6bd268f7168a8a0d187c93d5954d5ef93bfd
The source of the problem was the vim.lsp.tagfunc erroneously sending synchronous LSP requests during the insert completion, it has been fixed here: https://github.com/neovim/neovim/pull/37260
Maybe the workaround could be guarded with a nvim-0.12 check? It is strange to have to set the already-default options for tag completion to work as a fallback.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the mini.completion module and inspect the workaround introduced by commit eb4d6bd268f7168a8a0d187c93d5954d5ef93bfd. Compare its behavior with Neovim 0.12 and the fix described in Neovim PR 37260, then verify that the default vim.o.complete works without the slowdown while tag completion remains available as a fallback.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100