plenary.path: make_relative to return only relative paths

Open
#411 3 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
lua
Domain
tooling

Research direction

Start by locating the plenary.path.make_relative entry point and inspect how it handles the provided cwd and Path.filename values. Confirm the expected behavior with the issue's example, where /home/user/docs/tmp/note.md becomes ../../tmp/note.md, and add or update coverage if the relevant test location is found.

Written by the indexing model from the issue text.

Description

Hey :),
IMHO make_relative should return only relative paths, so:

  • cwd: /home/user/docs/neovim/docs/, Path.filename: /home/user/docs/tmp/note.md:
    should return: ../../tmp/note.md
    currently returns: /home/user/docs/tmp/note.md.

Happy to make a PR, I'd just like to confirm this behavior is desired not just by me, but also by others.

Dominant language
Lua
Stars
3.5k
Forks
340
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nvim-lua/plenary.nvim

All issues in nvim-lua/plenary.nvim

Similar issues

More Lua issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.