nvim-flutter / nvim-flutter/flutter-tools.nvim

[BUG] Wrap with widget code action does not enter select mode

Open
#426 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
1.4k
Forks
116
Avg merge
3m
Merged PRs (30d)
1

Description

Is there an existing issue for this?
  • I have searched the existing issues
Current Behavior

When using the 'Wrap with Widget' code action, a widget called "widget" is created. The cursor stays in the middle of the name and the placeholder is not selected.
2025-01-03-145301_sway-screenshot

Expected Behavior

It should enter select mode, allowing to select a widget. For example, when using the "Stateless widget" snippet, it creates a class called "MyWidget" and selects the name of the class. Entering text erases the placeholder.
2025-01-03-145456_sway-screenshot

It could also brind up a popup or query, for example as when renaming a variable.

Steps To Reproduce

I am using the following config (lazy.nvim):

  {
    "nvim-flutter/flutter-tools.nvim",
    dependencies = {
      "nvim-lua/plenary.nvim",
      "stevearc/dressing.nvim"
    },
    config = function ()
      local map = vim.keymap.set
      map("n", "fR", "<cmd> FlutterRun <cr>")
      map("n", "fd", "<cmd> FlutterDevices <cr>")
      map("n", "fr", "<cmd> FlutterRestart <cr>")
      map("n", "fo", "<cmd> FlutterOutlineToggle <cr>")
      require("flutter-tools").setup {
        flutter_lookup_cmd = "asdf where flutter",
        widget_guides = {
          enabled = true,
        }
      }
    end,
    ft = "dart"
  },

I have called the code action on the following snippet, at Placeholder

Widget test() {
  return Placeholder()
}
Environment
- OS:Fedora 40
- Flutter version: tested on
  - 3.19.5
  - 3.19.6
  - 3.22.0
  - 3.22.2
  - 3.24.3
  - 3.24.4

- Is flutter in $PATH: yes
- neovim version: 0.10.2
Anything else?

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Wrap with Widget code action on the provided Dart snippet at Placeholder, then trace the code-action entry point responsible for creating the widget name. The issue is done when the generated widget name is selected for replacement, matching the Stateless widget snippet behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
dart, flutter, lua, neovim
Domain
devtools, mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.