nuwave / nuwave/lighthouse

Switch test setup to MySQL 8

Open
#1,784 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

discussion
Dominant language
PHP
Stars
3.5k
Forks
468
Avg merge
3h 9m
Merged PRs (30d)
2

Description

The newest Ubuntu 20.04 in GitHub actions is now using MySQL 8: https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md#mysql.

MySQL 8.0 requires a new authentication method that is only supported in PHP 7.4+.defaults:
Once we drop support for older PHP versions, we can use ubuntu-20.04.
Also, default ordering semantics in MySQL 8 seem to have changed, so we will need
to change a bunch of assertJson() to assertSimilarJson().

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the GitHub Actions test setup and the tests using assertJson() first, then verify the project's PHP-version support constraint. Update the setup for Ubuntu 20.04/MySQL 8 and change affected assertions to assertSimilarJson(); done means the test suite passes with the newer MySQL authentication and ordering behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, mysql, php
Domain
ci-cd, databases, testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.