nuwave / nuwave/lighthouse

Support nested NOT in @whereConstraints

Open
#1,124 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
PHP
Stars
3.5k
Forks
468
Avg merge
3h 9m
Merged PRs (30d)
2

Description

When using @whereConstraints, it can be beneficial to nest complex expressions within a logical NOT operator.

While we had that feature in there, it actually did not work with complex sub-conditions, so i removed it for now.

There has been a proposal and a rejected PR to implement nesting conditions in a NOT boolean. Maybe we can workaround that or push for an implementation within Laravel.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the current @whereConstraints implementation, then compare the linked Laravel proposal and rejected PR to understand the unresolved approach. The work is done when complex sub-conditions can be nested within a NOT boolean and the behavior is covered by appropriate tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
graphql, laravel, php
Domain
api, backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.