nuts-foundation / nuts-foundation/nuts-node
Simplify X509CredentialValidator after generic validation refactor
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 28
- Forks
- 23
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 76
Description
Parent PRD
#4079
What to build
After CRL/cert-time validation has moved to the did:x509 resolver (#4083), key time-based checks have moved to the key resolver (#4084), and issuer attribute matching has moved to the generic Verify function (#4085), the X509CredentialValidator contains only duplicated logic.
- Remove the remaining duplicated logic from
X509CredentialValidator - Either simplify it to delegate to
defaultCredentialValidatoror remove it entirely - Simplify the
FindValidatordispatch inresolver.go— remove theX509CredentialTypecase if the validator is removed - Verify all existing tests pass with no behavior changes
Acceptance criteria
-
X509CredentialValidatorno longer contains CRL, cert-time, or policy assertion logic -
FindValidatordispatch is simplified or the X509 case is removed - All existing X509Credential tests pass unchanged
- All existing s2s flow tests pass unchanged
- No regression in credential validation behavior for any credential type
Blocked by
- Blocked by #4083 (CRL/cert-time in did:x509 resolver)
- Blocked by #4084 (key resolver time checks)
- Blocked by #4085 (generic attribute matching)
User stories addressed
- User story 7: existing behavior preserved
- User story 8: validation architecture follows PSA layered model
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting X509CredentialValidator and the FindValidator dispatch in resolver.go after blocked issues #4083, #4084, and #4085 are complete. Run the existing X509Credential and s2s flow tests before and after the refactor; done means the duplicated validation logic and unnecessary dispatch are removed without behavior changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- security
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100