nuts-foundation / nuts-foundation/nuts-node
Issues with signature verification during the summer/winter time change
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 28
- Forks
- 23
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 76
Description
While verifying signatures during the winter/summer change period errors occured where contracts where seen as yet to happen and validity false was returned while true was expected. For these cases the nutsnode produced the following logs:
time="2024-10-27T00:58:02Z" level=warning msg="Signature verification failed, reason: invalid contract text: invalid period: contract is not yet valid" module=Auth
This was happening about 5 minutes before the actuall time change would take effect. As checkTime parameter to the verify contract method UTC datetimes where used.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start from the contract verification method that receives the UTC checkTime parameter and reproduce verification around the reported summer/winter time change, using the provided log as the expected failure case. Trace how contract validity periods are evaluated and confirm that valid contracts verify correctly before and during the transition.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100