nuts-foundation / nuts-foundation/nuts-node
Add credentialSubject validation when we start using it
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 28
- Forks
- 23
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 76
Description
The credential_definition in credential requests may contain a credentialSubject field. Once we start using its value we also need to add validation for it. This should be added in CredentialDefinition.Validate() and ValidateDefinitionWithCredential
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading CredentialDefinition.Validate() and ValidateDefinitionWithCredential, then trace how credentialSubject is represented and used in credential requests. Define the validation behavior from the existing credential-definition rules and verify that both named validation paths reject invalid credentialSubject values while accepting valid ones.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend-api-design
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100