nuts-foundation / nuts-foundation/nuts-node
Crypto: Storage.ListKeys should be able to return an error
Open
Nobody has claimed this yet.
crypto
good first issue
- Dominant language
- Go
- Stars
- 28
- Forks
- 23
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 76
Description
Now returns an empty list in case of error, which was probably fine when we only had on-disk storage, but dangerous when using external backends.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Crypto storage Storage.ListKeys entry point and trace its callers and external-backend implementations. Confirm how backend failures are currently represented, then add coverage showing that a failure is returned as an error rather than an empty key list.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, security
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100