nuts-foundation / nuts-foundation/nuts-node
Consider validating JSON-LD properties more strictly
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 28
- Forks
- 23
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 76
Description
https://github.com/nuts-foundation/nuts-node/pull/1692 ensures all JSON-LD query properties of SearchVCs must be defined in the provided contexts. This can also be applied in the following spots:
- Auth: draw up contract (
auth/services/contract/notary.go:308) - Auth: validating issuer of access token (
auth/services/oauth/oauth.go:312) - DIDman: searching organizations (
didman/didman.go:403)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with PR #1692 to understand the existing JSON-LD query-property validation. Review auth/services/contract/notary.go at line 308, auth/services/oauth/oauth.go at line 312, and didman/didman.go at line 403. Done means the relevant JSON-LD properties in all three flows must be defined in their provided contexts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100