nuts-foundation / nuts-foundation/nuts-node
VCR: Better distinct VC Verify and Validate functions
Open
Nobody has claimed this yet.
vcr
- Dominant language
- Go
- Stars
- 28
- Forks
- 23
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 76
Description
We have both, and they do different things. But they're too ambigious.
See https://github.com/nuts-foundation/nuts-node/pull/1573#pullrequestreview-1157819114
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the pull request review linked in the issue, then locate the VCR Verify and Validate implementations in the repository. Compare what each function does and clarify their names so the distinction is unambiguous; done means the two functions are clearly differentiated without changing their separate responsibilities.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- security
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100