nusmodifications / nusmodifications/nusmods
Add module box enhancements
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 689
- Forks
- 364
- Avg merge
- 7h 5m
- Merged PRs (30d)
- 14
Description
-
Add FAB on mobile which will focus the add module box when selected
-
Remove hint text (Try ...) and only show module count when text is entered
-
Automatically select first item so that hitting enter will immediately add the first item to timetable
-
Make it more noticeable on desktop by using v2's input group format
-
Highlight search term in results - currently with 500 results this is too slow on mobile. Either find a way to virtualize the list, render the list async, or reduce the number of results (dangerous)
Also consider if it is a good idea to open upwards so that it doesn't cover the list of already selected modules on desktop.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the add module box and reviewing each unchecked enhancement against the existing mobile and desktop behavior. Decide the approach for the FAB, v2 input-group format, result highlighting or list performance, and upward opening; done means the selected improvements work on both relevant layouts without covering selected modules.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react, typescript
- Domain
- frontend, mobile-dev, web-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100