nusmodifications / nusmodifications/nusmods
Today page not handling boundary between semesters properly
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 689
- Forks
- 364
- Avg merge
- 7h 5m
- Merged PRs (30d)
- 14
Description
Refer to https://github.com/nusmodifications/nusmods/issues/3757#issuecomment-2383138799 for analysis of this issue.
Today dashboard display classes only according to days in week, not checking if the class is conducted on particular weeks
- Go to 'Today'
Expected behavior
Tutorial slot not showing up on 1 Aug, which only starts from week 1
Actual behavior
Slot showed up
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
- OS: MacOS
- Browser Chrome
- Version [20240726-3e1ce70]
Additional context
Add any other context about the problem here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the analysis in the linked issue comment, then open the Today page and reproduce the 1 Aug case described here. Trace how Today decides which classes to display across semester boundaries. Done means a tutorial that starts in week 1 is not shown on 1 Aug, while classes conducted that day still appear.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react, typescript
- Domain
- frontend, web-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100