nusmodifications / nusmodifications/nusmods

Previous system mods are not offered on NUSMods but are prompted in Planner

Open
#3,370 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

planner
Dominant language
JavaScript
Stars
689
Forks
364
Avg merge
7h 5m
Merged PRs (30d)
14

Description

Describe the bug

Some mods like MA1101R and MA1102R no longer exist but the Planner gives a warning that I need to clear it. I took these mods (Y2 here) but I can't seem to search for them either. So I'm stuck with the warning.

image

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Planner'
  2. Click on '+ Add Modules'
  3. Type down to 'MA1101R' in the text box
  4. There's no module like that anymore even though it once existed.
Expected behavior

It'd be nice to have NUSMods comply with the current academic requirements. OR, it'd be nice to have these mods present on NUSMods so that we can avoid the yellow warning boxes.

Screenshots

image
image

Desktop (please complete the following information):
  • OS: macOS
  • Browser: Safari
  • Version: 11.5.2

Thank you for your consideration!!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the Planner's Add Modules flow and reproduce the missing MA1101R or MA1102R search result and warning. Compare the module lookup with the planner's existing-module validation; done means previously taken modules no longer produce an unresolvable warning, or are otherwise supported as described by the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.