Replace `makeResponsive` with `useMediaQuery`
@BransonNg is already working on this.
Since Dec 8, 2020.
Assessment
This issue has not been assessed yet.
Description
useMediaQuery was added in #3007 to replace the makeResponsive higher order component. This issue tracks the removal of the deprecated makeResponsive from the codebase.
At the time of writing, there are 5 remaining components that use makeResponsive, 2 of which are function components. The remaining 3 class components will need to be replaced with function components first (similar to work done in #3007 and #3009).
This can be done over multiple PRs depending on your comfort level.
Update: only TodayContainer is left. VenuesContainer too, but that'll be done in #3038.
- Dominant language
- JavaScript
- Stars
- 689
- Forks
- 364
- Avg merge
- 7h 5m
- Merged PRs (30d)
- 14
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nusmodifications/nusmods
-
venue data
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
nusmodifications/nusmods#4571 ·
-
venue data
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
nusmodifications/nusmods#4570 ·
-
venue data
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
nusmodifications/nusmods#4563 ·
-
venue data
Difficulty 1/5 Under an hour Newbie friendliness 75/100
nusmodifications/nusmods#4559 ·
-
venue data
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
nusmodifications/nusmods#4556 ·
All issues in nusmodifications/nusmods
Similar issues
-
code-quality refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
github/gh-aw-firewall#8816 ·
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
optimization optimization:agents-md-curator
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
githubnext/gh-aw-cao#13143 ·
-
status: needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100