Replace `makeResponsive` with `useMediaQuery`

Open
#3,032 6 comments 0 reactions 1 assignee View on GitHub

@BransonNg is already working on this.

Since Dec 8, 2020.

Assessment

This issue has not been assessed yet.

Description

better engineering good first issue taken

useMediaQuery was added in #3007 to replace the makeResponsive higher order component. This issue tracks the removal of the deprecated makeResponsive from the codebase.

At the time of writing, there are 5 remaining components that use makeResponsive, 2 of which are function components. The remaining 3 class components will need to be replaced with function components first (similar to work done in #3007 and #3009).

This can be done over multiple PRs depending on your comfort level.

Update: only TodayContainer is left. VenuesContainer too, but that'll be done in #3038.

Dominant language
JavaScript
Stars
689
Forks
364
Avg merge
7h 5m
Merged PRs (30d)
14

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nusmodifications/nusmods

All issues in nusmodifications/nusmods

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.