nusmodifications / nusmodifications/nusmods
Minor styling issue for Map on Today page
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 689
- Forks
- 364
- Avg merge
- 7h 5m
- Merged PRs (30d)
- 14
Description
Describe the bug
The class component is a rounded rectangle. However, the map component is not. This creates a minor styling issue in the bottom corners of the class component.
To Reproduce
Steps to reproduce the behavior:
- Go to Today page
- Click on Open Map in one of the class
- See error
Expected behavior
The corner of the map should align with that of the outer component.
Screenshots
Styling issue in the corner:
Smartphone (please complete the following information):
- Device: iPhone XS
- OS: iOS13
- Browser: Safari
Additional context
This problem only appears on mobile browsers since desktop version uses a different layout.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by opening the Today page on a mobile browser and following Open Map from a class. Inspect the map and its surrounding class component, then verify that their bottom corners align on mobile while preserving the desktop layout.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- design, frontend, web-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100