nusmodifications / nusmodifications/nusmods

Ignore test files in hot reload TS config

Open
#1,792 0 comments 1 reaction 1 assignee View on GitHub

@ZhangYiJiang is already working on this.

Since Jun 22, 2019.

Dominant language
JavaScript
Stars
689
Forks
364
Avg merge
7h 5m
Merged PRs (30d)
14

Description

We might be able to speed up our dev hot reload build if we exclude test files from it. Using the ignore option in tsconfig.json (https://www.typescriptlang.org/docs/handbook/tsconfig-json.html), we can create a separate TS config just for dev.

This will also stop broken tests from blocking writing code, although it might also make broken tests less visible. I think the pros here outweigh the cons though.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.