nusmodifications / nusmodifications/nusmods

Footer overlaps with side navbar

Open
#1,646 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
689
Forks
364
Avg merge
7h 5m
Merged PRs (30d)
14

Description

Describe the bug

Minor non-blocking issue. The content of the navbar on the left of the page overlaps with the content of the footer.

To Reproduce

Steps to reproduce the behavior:

  1. Go to NUSMods homepage on a large screen device
  2. Scroll down to the bottom of the page
  3. See error
Expected behavior

The footer content should not be covered by the navbar content

Screenshots

Screenshots from the live beta website:

Large screen:
2019-03-28_01h00_48

Medium screen:
2019-03-28_01h05_15

Desktop (please complete the following information):
  • OS: [Windows]
  • Browser [Chrome]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the overlap on the NUSMods homepage at a large screen size, then inspect the footer and left navbar styling and layout. The work is done when scrolling to the bottom no longer allows navbar content to cover the footer on the reported screen sizes.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react, typescript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.