nusmodifications / nusmodifications/nusmods
Semester planner modules are clipped when dragged outside the semesters wrapper
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 689
- Forks
- 364
- Avg merge
- 7h 5m
- Merged PRs (30d)
- 14
Description
Describe the bug
On iOS dragging a module from semester area will be clipped. This does not reproduce on any other OS/browser. The module will still push down the other modules as expected, and if let go the module will be dropped successfully, so this is purely a visual glitch, but it is still quite annoying and makes the planner harder to use.
To Reproduce
Steps to reproduce the behavior:
- Add a module to the semester area
- Try to drag it outside the semester area, eg. to the exemptions list
- Notice the module is clipped / disappears
Expected behavior
The module should not be clipped
Smartphone / Tablet
- Device: iPad 9.7
- OS: iOS
- Browser: Safari Mobile
- Version: 12.1.1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the drag from the semester area to the exemptions list on an iPad using Safari Mobile 12.1.1, then inspect the semester wrapper and drag behavior involved. Done means the dragged module remains fully visible outside the semesters area while continuing to push other modules and drop successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend, web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100