Allow negative filters in module finder

Open
#1,372 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript, react, typescript
Domain
frontend, search

Research direction

Start by locating the module finder search UI and the search logic. Review how departments and faculties are currently selected and filtered, then implement the requested exclusion controls and confirm that excluded categories no longer appear in results.

Written by the indexing model from the issue text.

Description

good first issue module finder

Based on this feature request

I think an extremely useful search function would be to have the ability to exclude particular departments or faculties in the search, to clean up the number of results displayed.

Examples of this in the wild

screenshot from 2019-01-05 09-13-58

We will have to either add two buttons or make it a three state toggle - this is probably going to be a large change. The update to the search logic should be relatively straightforward

Dominant language
JavaScript
Stars
689
Forks
364
Avg merge
7h 5m
Merged PRs (30d)
14

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nusmodifications/nusmods

All issues in nusmodifications/nusmods

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.