nushell / nushell/vscode-nushell-lang
Custom file icon overrides icon themes
Nobody has claimed this yet.
- Dominant language
- Nushell
- Stars
- 153
- Forks
- 31
- PR merge metrics
- No merged PRs in 30d
Description
#77 introduced a custom file icon. Although neat it overrides file icon themes by default. AFAIK the only way to prevent that behavior is to add showLanguageModeIcons: false (like https://github.com/lineville/vscode-emoji-icons/blob/8e6cdc77686316dcdcd8b6142542299310ccd971/file-icons/emoji-icon-theme.json#L2) to each theme itself. The problem arises that many themes (like https://github.com/EliverLara/sweet-vscode-icons) are unmaintained. It's arguably VS Code's fault for not exposing a user toggle but unpleasant nonetheless.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the custom file icon introduced in #77 and the VS Code language default icons documentation linked in the issue. Compare the referenced emoji and Sweet VS Code icon theme JSON to understand how showLanguageModeIcons affects the override. Done requires identifying a workable way to preserve user-selected file icon themes, or documenting that the behavior cannot be changed here.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- vscode
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100