nushell / nushell/reedline

Cycling between maximize and minimize reprints the prompt on Windows

Open
#620 11 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-Display
Dominant language
Rust
Stars
818
Forks
249
Avg merge
4d 14h
Merged PRs (30d)
30

Description

Describe the bug

I updated nu to v0.60.0 on two Windows machines today. One of them runs Windows 11 Pro and other runs Windows 10 Enterprise. nu reprints the prompt when I maximize and minimize window.

On Windows 11 Pro, the reprint of prompt happens when I maximize and minimize using title bar controls. On Windows 10 Enterprise, this happens both when I use the title bar controls and when I click on taskbar icon to switch between the window of another program and nu.

Configuration check 1

On both the machines, Windows Terminal was set as the default terminal application and nu was configured to open with the Windows Terminal. To verify that the same thing happens on Windows Console Host, I set Windows Console Host as the default terminal application and launched nu.exe. I observed the same issue in this case too.

Configuration check 2

I also tried to check if this was something specifically related to the prompt configuration. I switched from default to starship and the same thing kept happening even with starship.

How to reproduce

On Windows 10 and 11:

  1. Launch nu.exe and minimize and maximize it a couple of times.
  2. You should be able to see prompt getting reprinted on each maximize minimize cycle.

On Windows 10:

  1. Try switching between previously opened window of another program and nu.exe by clicking on nu.exe icon on taskbar.
  2. You should again be able to see prompt getting reprinted on each maximize minimize cycle.
Expected behavior

The prompt should not get reprinted in this case.

Screenshots

No response

Configuration
key value
version 0.60.0
short_commit 74af31a4
commit_hash 74af31a42ff4feb8d5d9897c0d99c7434678a315
commit_date 2022-03-22 19:07:11 +00:00
build_os windows-x86_64
rust_version rustc 1.59.0 (9d1b2106e 2022-02-23)
rust_channel stable-x86_64-pc-windows-msvc
cargo_version cargo 1.59.0 (49d8809dc 2022-02-10)
pkg_version 0.60.0
build_time 2022-03-22 19:26:49 +00:00
build_rust_channel release
features dataframe, default, trash, which, zip
installed_plugins
Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with nu.exe on Windows 10 and Windows 11 by maximizing, minimizing, and switching windows as described. Trace the prompt redraw handling for these window events; done means the prompt is not reprinted during any of the reported maximize, minimize, or taskbar-switching cycles.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.