"cell path" vs "cellpath" and similar
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 40.5k
- Forks
- 2.3k
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 85
Description
Describe the bug
I noticed looking around the styling logic that we look up the name to style from the type. For most things, this will work okay, but when the type's name includes a space, like "cell path" this won't match the styling name in the config file.
We probably should go through and make this work a bit better and make sure all items can be styled.
How to reproduce
- see above
Expected behavior
All common items can be styled, regardless of the type name.
Screenshots
No response
Configuration
| key | value |
|---|---|
| version | 0.83.2 |
| branch | main |
| commit_hash | d25df9c00b5b34827fd7b286534a6bebc4b39512 |
| build_os | macos-aarch64 |
| build_target | aarch64-apple-darwin |
| rust_version | rustc 1.69.0 (84c898d65 2023-04-16) |
| rust_channel | 1.69.0-aarch64-apple-darwin |
| cargo_version | cargo 1.69.0 (6e9a83356 2023-04-12) |
| build_time | 2023-08-02 11:24:52 +12:00 |
| build_rust_channel | release |
| allocator | standard |
| features | default, sqlite, trash, which, zip |
| installed_plugins |
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the styling lookup from an item's type name to the configuration key, using the reported "cell path" versus "cellpath" case as the reproduction. Confirm how other names with spaces are represented, then verify that all common items can be styled regardless of type-name formatting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100