Move file icons, LS_COLORS related code from `grid` / `table` to a dedicated command
Open
Nobody has claimed this yet.
category:enhancement
status:needs-triage
- Dominant language
- Rust
- Stars
- 40.5k
- Forks
- 2.3k
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 79
Description
Basics
- I have done a basic search through the issue tracker to find similar or related issues.
- I have made myself familiar with the available features of Nushell for the particular area this enhancement request touches.
Related problem
For file path rendering ls | grid --icons --color/ ls | table --icons, grid/table have special handling for "file path like" inputs.
I feel it really odd to implement it in current way.
The flag --icons is simply meaningless for most of the cases.
Describe the solution you'd like
https://github.com/nushell/nushell/pull/17248#discussion_r2649454916
Describe alternatives you've considered
A icon metadata protocol for general icon rendering.
Additional context and details
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the existing file path rendering and LS_COLORS handling in the grid and table commands, then read the discussion linked from PR #17248. The work is done when that special handling has been moved to a dedicated command with a clearly defined approach for icon rendering.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100