Engine should not crash on encountering assembly that cannot be examined
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 234
- Forks
- 163
- Avg merge
- 13h 32m
- Merged PRs (30d)
- 25
Description
See https://github.com/nunit/nunit-console/issues/794.
Currently, if the engine is passed an assembly that it cannot examine, the engine throws an exception. This was the correct behaviour at the time of implementation, however our handling of invalid assemblies has since improved.
We should instead suppress the crash, and create some form of NotRunnableFrameworkDriver for the assembly. That will allow the engine and various runners to produce more user-friendly error messages for these cases.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the engine path that examines assemblies and the handling of invalid assemblies, then read the linked nunit-console issue 794 for context. The change is complete when an unexaminable assembly no longer crashes the engine, is represented by a NotRunnableFrameworkDriver, and runners can produce user-friendly error messages.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100